ilariapet opened a new pull request, #3919: URL: https://github.com/apache/solr/pull/3919
https://issues.apache.org/jira/browse/SOLR-17843 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-####: <short description of problem or changes> SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description 1) In the TextToVectorUpdateProcessor, the vector is provided to the document with the `addField()` method. That means that if there is an existing vector in the output field, Solr will concatenate both vectors instead of overriding the existing one. 2) The TextToVectorUpdateProcessor is not behaving as expected when handling partial updates. In particular: - the value passed to the model for vectorisation incorrectly includes the `{set=` keyword instead of the actual raw value; - using the boolean `vectorised` field to trigger the vectorisation chain does not work as intended. # Solution 1) Use `setField()` instead of `addField()` 2) Add the `DistributedUpdateProcessorFactory` at the beginning of the `updateRequestProcessorChain`, before the `TextToVectorUpdateProcessor`. This component is responsible for correctly processing partial (atomic) updates. The Solr documentation has been updated accordingly. # Tests - A test verifies that when using a processor chain configured for partial updates (i.e., the UpdateRequestProcessor is placed before the TextToVector processor), the system correctly retrieves the stored value of the input field and generates the vector for the document. - A test verifies that when using a processor chain that does not support partial updates, vectorisation is not triggered, and no vector field is created for the document. - A test verifies that when a document already contains a vector, and the input field is modified using an atomic update, the vector is recomputed and replaces the previous one. It ensures that the system does not append or merge vector values. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. - [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [ ] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
