ilariapet commented on code in PR #3919: URL: https://github.com/apache/solr/pull/3919#discussion_r2610479517
########## solr/modules/language-models/src/test-files/solr/collection1/conf/schema.xml: ########## @@ -20,6 +20,7 @@ <schema name="schema-densevector" version="1.7"> <fieldType name="string" class="solr.StrField" multiValued="true"/> + <fieldType name="boolean" class="solr.BoolField" sortMissingLast="true"/> Review Comment: I added a test that verifies the vectorisation trigger using the `vectorised` boolean field. Since the schema didn’t previously include a boolean type, I needed to add it. It’s just an additional field, so it shouldn’t impact any of the other tests, right? ########## solr/modules/language-models/src/test-files/solr/collection1/conf/schema.xml: ########## @@ -37,8 +38,9 @@ <field name="string_field" type="string" indexed="true" stored="true" multiValued="false" required="false"/> <field name="_version_" type="plong" indexed="true" stored="true" multiValued="false" /> - <field name="_text_" type="text_general" indexed="true" stored="false" multiValued="true"/> - <copyField source="*" dest="_text_"/> + <field name="_text_" type="text_general" indexed="true" stored="true" multiValued="true"/> Review Comment: You’re right in this case. I should avoid modifying this schema. I’ll update the schema and tests accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
