malliaridis commented on PR #2818: URL: https://github.com/apache/solr/pull/2818#issuecomment-2480897920
> > The current state of the PR seems to not integrate the Angular project into the current "deployment", resulting in CORS issues when running with `npm start`. Do you have any instructions on how to run it so that we can see the UI in action? > 3. That's correct, I didn't invest enough time to merge to two different approaches to work under same server, usually for that is responsible app server in our case, it must be done via web.xml + might be require additional filter or something changes in the java app itself to consume and work with two approaches. Thanks. So that would still be an open TODO in case we decide to proceed with this one. > > A short feedback about improving the quality of your PR: [...] > > Okay, I'll try to revert most of the changes related to the current solution back that it won't affect PR. This now way easier to review, thanks a lot. > > I would also like to have a documentation that provide resources for further reading or basic ideas behind things like project structure (of the frontend of course). I think this would give our current community an easier start for both reviewing and working with the code. > > Well, I'm not sure what do you mean under the documentation with this. If you're speaking about the documentation such as README file then I will add one how to start local environment, until we'll have complete integration with backend solution, it won't help. I hope I correctly understood you. Yes, what I (and probably others as well) would like to see is how it would integrate into the current project (which is as described above an open TODO), how someone would work and test the code base (like running the UI with `npm ng serve`), and where the webapp can be accessed / seen (like at `localhost:3000`). I believe the module's / angular project's README file is the best place to tell other developers how to get started with this sub-project. Angular already provides some basic information, this could be extended. > > Starting and testing the current UI seems also not to be working in this PR, which would be necessary for other reviewers to form an opinion. > > [...] > If you're speaking about the way how to start and poke review it. Then I do everything from `package.json` until we integrated it with current backend solution. I meant starting and poking around, yes. So there is no state yet that makes request to a Solr backend, is that correct? I think you removed a few too manyfiles in your latest updates. The environment files under `/src/environments` are missing and causing an error when launching the app with `ng serve`. And one last tip, it's fine and also recommended to include `package-lock.json` in the VCS, as it ensures reproducable states of the project. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
