gus-asf commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1548461234
##########
solr/core/src/java/org/apache/solr/search/Grouping.java:
##########
@@ -461,7 +463,7 @@ private void searchWithTimeLimiter(final Query filterQuery,
Collector collector)
log.info("Query: {}; ", query);
// to make WARN logged exception content more visible
log.warn("Query: {}; ", query.getClass().getName(), x);
- qr.setPartialResults(true);
+ qr.setPartialResults(shouldKeepPartials());
Review Comment:
This seemed simplest and more readable. Code checks this value upstream in
addition to it getting reported in the final output. Maybe if I track those
down and ensure the up stream parsing handles it, this could be set to
"omitted" that could remove the need for an additional response header value
hmm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
