gus-asf commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1545939078
##########
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java:
##########
@@ -227,18 +243,27 @@ public ShardResponse takeCompletedOrError() {
private ShardResponse take(boolean bailOnError) {
try {
+ // although nothing in this class guarantees that pending has been
incremented to the total
Review Comment:
@CaoManhDat if you can double check my reading of this code and let me know
if this comment is inaccurate in any way I'd appreciate it. (I see your name in
the git blame a bunch here)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
