gus-asf commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1548457046
##########
solr/core/src/java/org/apache/solr/request/json/RequestUtil.java:
##########
@@ -216,24 +222,26 @@ public static void processParams(
boolean isQuery = false;
boolean arr = false;
if ("query".equals(key)) {
- out = "q";
+ out = Q;
isQuery = true;
// if the value is not a String, then it'll get converted to a
localParams query String.
// Only the "lucene" query parser can parse it. Ignore anything
else that may exist.
if (!(entry.getValue() instanceof String)) {
newMap.put(QueryParsing.DEFTYPE, new String[] {"lucene"});
}
} else if ("filter".equals(key)) {
- out = "fq";
+ out = FQ;
arr = true;
isQuery = true;
} else if ("fields".equals(key)) {
- out = "fl";
+ out = FL;
arr = true;
} else if ("offset".equals(key)) {
- out = "start";
+ out = START;
+ } else if ("allowPartialResults".equals(key)) {
Review Comment:
Hmm I didn't perceive the mechanism by which it would be respected without
this. I'll look again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
