gus-asf commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1548452698


##########
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java:
##########
@@ -497,7 +495,12 @@ public void handleRequestBody(SolrQueryRequest req, 
SolrQueryResponse rsp) throw
           debug.add("explain", new NamedList<>());
           rb.rsp.add("debug", debug);
         }
-        rb.rsp.setPartialResults();
+        if (req.shouldDiscardPartials()) {
+          // TODO: this isn't actually showing up... possibly need to do tis 
at a different point.
+          rb.rsp.getResponseHeader().add("partialResultsOmitted", "true");

Review Comment:
   :+1: 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to