gus-asf commented on code in PR #2379:
URL: https://github.com/apache/solr/pull/2379#discussion_r1560188805
##########
solr/core/src/java/org/apache/solr/search/Grouping.java:
##########
@@ -461,7 +463,7 @@ private void searchWithTimeLimiter(final Query filterQuery,
Collector collector)
log.info("Query: {}; ", query);
// to make WARN logged exception content more visible
log.warn("Query: {}; ", query.getClass().getName(), x);
- qr.setPartialResults(true);
+ qr.setPartialResults(shouldKeepPartials());
Review Comment:
Next commit will contain the "omitted" value I mention, but discussion
elsewhere indicates that even though I can maintain back compat it creates a
tricky situation where the attribute is only sometimes boolean (and unquoted in
the json) and other times can be a string (with quotes). I'm probably better
off just deprecating the partialResults flag and making a new string based
attribute, perhaps "partialResultStatus" that can be "complete results",
"partial results" or "results omitted" - that will come in the following commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
