epugh commented on code in PR #1218:
URL: https://github.com/apache/solr/pull/1218#discussion_r1096788848
##########
solr/solrj/src/test/org/apache/solr/client/solrj/GetByIdTest.java:
##########
@@ -30,7 +35,9 @@ public class GetByIdTest extends EmbeddedSolrServerTestBase {
@BeforeClass
public static void beforeClass() throws Exception {
- initCore();
+ solrClientTestRule.startSolr(LuceneTestCase.createTempDir("solrhome"));
Review Comment:
Why do some use
`solrClientTestRule.startSolr(Paths.get(SolrTestCaseJ4.TEST_HOME()));` and some
need their own temp dir like in this? Maybe this is really asking about some
documentation somewhere on how to write good tests that use this Rule?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
