wrunderwood commented on a change in pull request #96:
URL: https://github.com/apache/solr/pull/96#discussion_r643443328
##########
File path:
solr/core/src/java/org/apache/solr/util/circuitbreaker/CPUCircuitBreaker.java
##########
@@ -110,6 +113,27 @@ public double getCpuUsageThreshold() {
}
protected double calculateLiveCPUUsage() {
- return operatingSystemMXBean.getSystemLoadAverage();
+ Metric metric = this.core
+ .getCoreContainer()
+ .getMetricManager()
+ .registry("solr.jvm")
+ .getMetrics()
+ .get("os.systemCpuLoad");
Review comment:
The documentation and the linked Wikipedia page give more information on
load average.
Load average is a "system" load average, not just CPU. From Wikipedia:
"An idle computer has a load number of 0 (the idle process isn't counted).
Each process using or waiting for CPU (the ready queue or run queue) increments
the load number by 1. Each process that terminates decrements it by 1. Most
UNIX systems count only processes in the running (on CPU) or runnable (waiting
for CPU) states. However, Linux also includes processes in uninterruptible
sleep states (usually waiting for disk activity), which can lead to markedly
different results if many processes remain blocked in I/O due to a busy or
stalled I/O system."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
