bharathgunapati commented on code in PR #54:
URL:
https://github.com/apache/flink-connector-http/pull/54#discussion_r3989267627
##########
docs/content/docs/connectors/datastream/http.md:
##########
@@ -61,22 +61,31 @@ These options are specified on the builder using the
setProperty method.
| sink.requests.max-buffered | optional | Maximum
number of buffered records before applying backpressure.
|
| sink.flush-buffer.size | optional | The
maximum size of a batch of entries that may be sent to the HTTP endpoint
measured in bytes.
|
| sink.flush-buffer.timeout | optional |
Threshold time in milliseconds for an element to be in a buffer before being
flushed.
|
-| flink.connector.http.sink.request-callback | optional |
Specify which `HttpPostRequestCallback` implementation to use. By default, it
is set to `slf4j-logger` corresponding to `Slf4jHttpPostRequestCallback`.
|
Review Comment:
Thanks — this was only a docs fix. We did not remove a runtime option.
`flink.connector.http.*` was never read by the connector. The real prefix
has always been `http.`:
https://github.com/apache/flink-connector-http/blob/main/flink-connector-http/src/main/java/org/apache/flink/connector/http/config/HttpConnectorConfigConstants.java#L39
```java
public static final String FLINK_CONNECTOR_HTTP = "http.";
```
DataStream `setProperty(...)` only uses keys like `http.sink.*` and
`http.security.*`.
The DataStream docs had the wrong prefix, so those listed keys did nothing
if someone copied them. The code samples on the same page already used `http.*`.
If we keep `flink.connector.http.*` in the docs and mark it deprecated, it
would look like those keys still work. I would rather document only the keys
the runtime actually uses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
