bharathgunapati commented on code in PR #54:
URL:
https://github.com/apache/flink-connector-http/pull/54#discussion_r3951298773
##########
docs/content.zh/docs/connectors/datastream/http.md:
##########
@@ -61,22 +61,31 @@ These options are specified on the builder using the
setProperty method.
| sink.requests.max-buffered | optional | Maximum
number of buffered records before applying backpressure.
|
| sink.flush-buffer.size | optional | The
maximum size of a batch of entries that may be sent to the HTTP endpoint
measured in bytes.
|
| sink.flush-buffer.timeout | optional |
Threshold time in milliseconds for an element to be in a buffer before being
flushed.
|
-| flink.connector.http.sink.request-callback | optional |
Specify which `HttpPostRequestCallback` implementation to use. By default, it
is set to `slf4j-logger` corresponding to `Slf4jHttpPostRequestCallback`.
|
Review Comment:
one docs follow-up worth calling out.
While documenting the new sink options, I found that the DataStream connector
page listed properties under a `flink.connector.http.*` prefix. The runtime
prefix has been `http.*` since the GetInData donation (`FLINK_CONNECTOR_HTTP
=
"http."`), and the same page's code samples already used `http.sink.*`. So
those
table/prose rows documented keys that were silently ignored if copied.
I've fixed this in `5d6bf70` / `95a71a1` for the DataStream docs (en + zh):
- corrected existing sink option keys to `http.*`
- added rows for the new status-code and retry-strategy options introduced by
this PR
- kept `http.sink.max-retries` default `0`, and restored
`http.sink.writer.thread-pool.size` default to `4` so unset jobs keep the
previous runtime behaviour
Table docs already used the correct `http.*` prefix; they only needed the new
option rows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
