davidradl commented on code in PR #54:
URL:
https://github.com/apache/flink-connector-http/pull/54#discussion_r3989117196
##########
docs/content.zh/docs/connectors/table/http.md:
##########
@@ -596,12 +596,21 @@ another format name.
| http.sink.request-callback | optional | Specify which
`HttpPostRequestCallback` implementation to use. By default, it is set to
`slf4j-logger` corresponding to `Slf4jHttpPostRequestCallback`.
|
| http.sink.error.code | optional | List of HTTP status
codes that should be treated as errors by HTTP Sink, separated with comma.
|
| http.sink.error.code.exclude | optional | List of HTTP status
codes that should be excluded from the `http.sink.error.code` list, separated
with comma.
|
+| http.sink.success-codes | optional | Comma separated HTTP
status codes considered as successful sink responses. Use [1-5]XX for groups
and `!` for exclusions. The default is `2XX`. Ignored when the legacy
`http.sink.error.code` properties are set. |
Review Comment:
I suggest we error if both legacy and new option are specified and only
allow one or the other. If they are specifying the new options they likely want
to use them but did not reliase to remove the old one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
