davidradl commented on code in PR #54:
URL:
https://github.com/apache/flink-connector-http/pull/54#discussion_r3989138504
##########
docs/content/docs/connectors/datastream/http.md:
##########
@@ -61,22 +61,31 @@ These options are specified on the builder using the
setProperty method.
| sink.requests.max-buffered | optional | Maximum
number of buffered records before applying backpressure.
|
| sink.flush-buffer.size | optional | The
maximum size of a batch of entries that may be sent to the HTTP endpoint
measured in bytes.
|
| sink.flush-buffer.timeout | optional |
Threshold time in milliseconds for an element to be in a buffer before being
flushed.
|
-| flink.connector.http.sink.request-callback | optional |
Specify which `HttpPostRequestCallback` implementation to use. By default, it
is set to `slf4j-logger` corresponding to `Slf4jHttpPostRequestCallback`.
|
Review Comment:
I assume we should not removed existing config options from the code - as
this would break migrations. In this case we should keep the docs - maybe with
a deprecated indicator and suggestions on what should be used instead for each.
We should not reprefix the legacy config options I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
