davidradl commented on code in PR #54:
URL:
https://github.com/apache/flink-connector-http/pull/54#discussion_r3989322517
##########
flink-connector-http/src/main/java/org/apache/flink/connector/http/config/HttpConnectorConfigConstants.java:
##########
@@ -138,6 +138,38 @@ public final class HttpConnectorConfigConstants {
public static final String SINK_HTTP_WRITER_THREAD_POOL_SIZE =
FLINK_CONNECTOR_HTTP + "sink.writer.thread-pool.size";
+ public static final String SINK_MAX_RETRIES = FLINK_CONNECTOR_HTTP +
"sink.max-retries";
+
+ public static final String SINK_SUCCESS_CODES = FLINK_CONNECTOR_HTTP +
"sink.success-codes";
Review Comment:
I wonder if we should not have sink at all in the options common to sink and
lookup and only have sink or lookup if it is sink or lookup specific. We could
use withDeprecatedKeys in the configuration. This would get rid of a lot of the
duplicate config keys across sink and lookup. And we may be able to have common
code to process the common options as far as possible. We could re-origanise
the docs into a common section and then a section for sink and look up
specifics.
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
