xishuaidelin commented on code in PR #26616:
URL: https://github.com/apache/flink/pull/26616#discussion_r2122878209
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java:
##########
@@ -310,6 +314,21 @@ protected Transformation<RowData> createJoinTransformation(
} else {
StreamOperatorFactory<RowData> operatorFactory;
if (isAsyncEnabled) {
+ if (asyncLookupOptions.keyOrdered) {
+ return createKeyOrderedAsyncLookupJoin(
Review Comment:
Actually we need to add a new transformation in key-ordered mode here. The
existing createAsyncLookupJoin method is to generate a StreamOperatorFactory. A
new method would be more clear .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
