davidradl commented on code in PR #26616:
URL: https://github.com/apache/flink/pull/26616#discussion_r2115626093
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java:
##########
@@ -481,7 +516,14 @@ private StreamOperatorFactory<RowData>
createAsyncLookupJoin(
isLeftOuterJoin,
asyncLookupOptions.asyncBufferCapacity);
}
-
+ if (asyncLookupOptions.keyOrdered) {
+ checkNotNull(keySelector);
+ return new TableKeyedAsyncWaitOperatorFactory<>(
Review Comment:
I wonder if we need a new TableKeyedAsyncWaitOperatorFactory class, then
there is the existing factory AsyncWaitOperatorFactory which seems the same
apart from the keyselector parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
