davidradl commented on code in PR #26616:
URL: https://github.com/apache/flink/pull/26616#discussion_r2128191954
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java:
##########
@@ -310,6 +314,21 @@ protected Transformation<RowData> createJoinTransformation(
} else {
StreamOperatorFactory<RowData> operatorFactory;
if (isAsyncEnabled) {
+ if (asyncLookupOptions.keyOrdered) {
+ return createKeyOrderedAsyncLookupJoin(
Review Comment:
would it not be clearer to have a transformation to do the ordering then
call the existing method to do the createAsyncLookupJoin at this level - rather
than deeper in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
