davidradl commented on code in PR #26616:
URL: https://github.com/apache/flink/pull/26616#discussion_r2115584086
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -374,6 +374,15 @@ public class ExecutionConfigOptions {
// ------------------------------------------------------------------------
// Async Lookup Options
// ------------------------------------------------------------------------
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Boolean>
TABLE_EXEC_ASYNC_LOOKUP_KEY_ORDERED =
+ key("table.exec.async-lookup.key-ordered-enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "When true async lookup joins would follow the
upsert key order in cdc stream (if no upsert key, "
Review Comment:
We should indicate why a use might set this. We think that there isa
performance improvement in some cases, but the sorting must be extra
processing. We should mention this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
