xishuaidelin commented on code in PR #26616:
URL: https://github.com/apache/flink/pull/26616#discussion_r2122774679
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java:
##########
@@ -374,6 +374,15 @@ public class ExecutionConfigOptions {
// ------------------------------------------------------------------------
// Async Lookup Options
// ------------------------------------------------------------------------
+ @Documentation.TableOption(execMode =
Documentation.ExecMode.BATCH_STREAMING)
+ public static final ConfigOption<Boolean>
TABLE_EXEC_ASYNC_LOOKUP_KEY_ORDERED =
+ key("table.exec.async-lookup.key-ordered-enabled")
+ .booleanType()
+ .defaultValue(false)
+ .withDescription(
+ "When true async lookup joins would follow the
upsert key order in cdc stream (if no upsert key, "
Review Comment:
Hi, @davidradl . Sorry for my late reply and thanks for your good catch
here.
This optimization does not apply to insert-only streams because its purpose
is to enable potential unordered optimizations in ordered scenarios. For
insert-only stream, if allow_unordered is enabled then it has already undergone
unordered processing. In another word, we don't expect to change the current
behaviour on insert-only streams.
` private static AsyncDataStream.OutputMode convert(
ChangelogMode inputChangelogMode,
ExecutionConfigOptions.AsyncOutputMode asyncOutputMode) {
if (inputChangelogMode.containsOnly(RowKind.INSERT)
&& asyncOutputMode ==
ExecutionConfigOptions.AsyncOutputMode.ALLOW_UNORDERED) {
return AsyncDataStream.OutputMode.UNORDERED;
}
return AsyncDataStream.OutputMode.ORDERED;
}`
I would clarify this in the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
