XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505976015
########## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ########## Review Comment: Thanks for clarifying things. I tried to come up with a proposal for a test. But to be fair, even that one is not perfect (you want to avoid weakening the accessibility of production code for tests). It hard to achieve in other ways because of the way the classes are structured (as you already pointed out). Doing it properly would require a larger refactoring. Have a look at LadyForest/flink#1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
