LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505838606
########## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ########## Review Comment: Personally, I believe the crux of the problem is that `FileSystemTableSink#toStagingPath` acts like a remote time bomb, which only detonates within `FileSystemOutputFormat` when multiple sinks write to the same physical table and create the staging directory at the exact same time. Because it spans multiple components, constructing a unit test is quite challenging. Another approach would be to add an ITCase (in fact, that unstable case could, to some extent, be considered an ITCase for this issue). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
