XComp commented on code in PR #24390:
URL: https://github.com/apache/flink/pull/24390#discussion_r1505818193
##########
flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/FileSystemTableSink.java:
##########
@@ -374,7 +374,10 @@ public DynamicTableSource.DataStructureConverter
createDataStructureConverter(
}
private Path toStagingPath() {
- Path stagingDir = new Path(path, ".staging_" +
System.currentTimeMillis());
+ // Add a random UUID to prevent multiple sinks from sharing the same
staging dir.
+ // Please see FLINK-29114 for more details
+ Path stagingDir =
+ new Path(path, ".staging_" + UUID.randomUUID() +
System.currentTimeMillis());
Review Comment:
The last two sentences are contradicting. ;-) But I'm fine if you think that
the timestamp is helpful. But you might want to add a separator between the
time and the UUID. And you might want to put the timestamp before the UUID if
you think it's helpful for troubleshooting (for the sake of ordering by file
name).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
