XComp commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505832996
########## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ########## Review Comment: > [...] the issue is triggered when the FileSystemOutputFormat#finalizeGlobal method is called (triggered by the final block). I cannot confirm that. The change code segment isn't covered by the newly added tests. As said, reverting your fix in `FileSystemTableSink` doesn't make any of the tests fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
