LadyForest commented on code in PR #24390: URL: https://github.com/apache/flink/pull/24390#discussion_r1505871123
########## flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/table/FileSystemOutputFormatTest.java: ########## Review Comment: > As said, reverting your fix in `FileSystemTableSink` doesn't make any of the tests fail. This is because the test does not call any method defined `FileSystemTableSink`. However, it simulates the condition where two sinks share the same stagingDir which is denoted by the variable `tmpPath`. Do you think it would be a good idea if I made FileSystemTableSink#toStagingPath a static method, added the VisibleForTesting annotation, and called it in FileSystemOutputFormatTest? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
