echauchot commented on code in PR #23:
URL: 
https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1394495515

##########
module-with-no-tests/src/main/java/org/apache/flink/connector/testing/SomeClass2.java:
##########
@@ -19,4 +19,7 @@
 package org.apache.flink.connector.testing;
 
 /** A dummy class; only exists so that the compile/packaging plugins have 
something to do. */
-public class SomeClass {}
+public class SomeClass2 {

Review Comment:
   not modified: the original class is still named SomeClass and is located in 
module-with-tests module (the former test-project). This SomeClass2 is another 
one for the module-with-no-tests module.
   
   I can also have both classes named SomeClass and introduce different 
packages for module-with-tests and module-with-no-tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to