echauchot commented on code in PR #23:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1383402031
##########
.github/workflows/ci.yml:
##########
@@ -88,6 +93,10 @@ jobs:
if: ${{ inputs.run_dependency_convergence }}
run: echo
"MVN_DEPENDENCY_CONVERGENCE=-Dflink.convergence.phase=install
-Pcheck-convergence" >> $GITHUB_ENV
+ - name: "Disable archunit tests"
+ if: ${{ inputs.skip_archunit_tests }}
+ run: echo "MVN_ARCHUNIT_TESTS=-Dtest='!*ArchitectureTest'" >>
$GITHUB_ENV
Review Comment:
> It doesn't. To be more explicit than @snuyanzin, this will fail in
flink-sql-connector-* modules since they contain no tests. Naturally it works
in the Cassandra repo because it doesn't have a sql-connector module, nor any
module without any tests.
Ah, the failure was about a module with no tests at all, it was written
"without archunit tests". Indeed, in that case it does not work. Thanks for the
precision Chesnay.
> Surefire exclusions are the way to go, but we can't set these on the
command-line since it'd override the unit/it test separation setup in the
parent pom.
I'd suggest to add another property to the connector parent pom (e.g.,
additionalExcludes), which it adds to the surefire exclusions.
This should then "just work".
Yes, at first I submitted [this
PR](https://github.com/apache/flink-connector-shared-utils/pull/22/files) that
added surefire exclusions to the parent pom by adding a custom profile but it
had this drawback indeed. Of course I can add a property to add to already
defined exclusions. The drawback I see that I wanted to avoid is that it
modifies the parent pom leading to the need to release flink-connector-parent
and to bump its version in the connectors. But I guess this trade-off is
acceptable considering the sql modules problem above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
