echauchot commented on code in PR #23:
URL:
https://github.com/apache/flink-connector-shared-utils/pull/23#discussion_r1394491058
##########
pom.xml:
##########
@@ -48,7 +52,41 @@ under the License.
<artifactId>flink-test-utils-junit</artifactId>
<version>${flink.version}</version>
<scope>test</scope>
+ <!-- for dependency convergence -->
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.commons</groupId>
+
<artifactId>commons-compress</artifactId>
+ </exclusion>
+ </exclusions>
</dependency>
+
+ <!-- ArchUit test dependencies -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-architecture-tests-test</artifactId>
Review Comment:
I agree, updates are a problem but I thought that test-project was a
template for connectors projects. As, all the connectors rely on flink rules,
shouldn't test project too ?
If test-project is not intended to be a template for new connectors, but
just a test project for the CI env, then I can definitely just create a single
local rule for production classes and one for test classes. would you prefer
that ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
