gyfora commented on code in PR #357:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/357#discussion_r959205041
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java:
##########
@@ -141,41 +148,19 @@ protected void observeJmDeployment(
return;
}
- Optional<Deployment> deployment =
context.getSecondaryResource(Deployment.class);
- if (deployment.isPresent()) {
- DeploymentStatus status = deployment.get().getStatus();
- DeploymentSpec spec = deployment.get().getSpec();
- if (status != null
- && status.getAvailableReplicas() != null
- && spec.getReplicas().intValue() == status.getReplicas()
- && spec.getReplicas().intValue() ==
status.getAvailableReplicas()
- && flinkService.isJobManagerPortReady(effectiveConfig)) {
-
- // typically it takes a few seconds for the REST server to be
ready
- logger.info(
- "JobManager deployment port is ready, waiting for the
Flink REST API...");
- deploymentStatus.setJobManagerDeploymentStatus(
- JobManagerDeploymentStatus.DEPLOYED_NOT_READY);
+ if
(KubernetesDeploymentMode.NATIVE.equals(flinkApp.getSpec().getMode())) {
+ Optional<Deployment> deployment =
context.getSecondaryResource(Deployment.class);
+ if (deployment.isPresent()) {
+ jmDeploymentObserver(deployment.get(), effectiveConfig,
deploymentStatus, flinkApp);
return;
Review Comment:
I think you can have PVC with the current podTemplate also right?
Also the JM doesn’t access much data during recovery , so even if it has to
fetch it from remote storage it wouldn’t really have a big impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
