gyfora commented on code in PR #357:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/357#discussion_r958613729
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java:
##########
@@ -141,41 +148,19 @@ protected void observeJmDeployment(
return;
}
- Optional<Deployment> deployment =
context.getSecondaryResource(Deployment.class);
- if (deployment.isPresent()) {
- DeploymentStatus status = deployment.get().getStatus();
- DeploymentSpec spec = deployment.get().getSpec();
- if (status != null
- && status.getAvailableReplicas() != null
- && spec.getReplicas().intValue() == status.getReplicas()
- && spec.getReplicas().intValue() ==
status.getAvailableReplicas()
- && flinkService.isJobManagerPortReady(effectiveConfig)) {
-
- // typically it takes a few seconds for the REST server to be
ready
- logger.info(
- "JobManager deployment port is ready, waiting for the
Flink REST API...");
- deploymentStatus.setJobManagerDeploymentStatus(
- JobManagerDeploymentStatus.DEPLOYED_NOT_READY);
+ if
(KubernetesDeploymentMode.NATIVE.equals(flinkApp.getSpec().getMode())) {
+ Optional<Deployment> deployment =
context.getSecondaryResource(Deployment.class);
+ if (deployment.isPresent()) {
+ jmDeploymentObserver(deployment.get(), effectiveConfig,
deploymentStatus, flinkApp);
return;
Review Comment:
If these are the only advantages I would prefer Deployment:
1. Native integration has the random suffix, not a problem you can select
by label if necessary
2. Not sure why you need a PVC for the JM
3. There is not a good reason to have more than one 1 replica and even then
PVC is not necessary anyways
@wangyang0918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
