Grypse commented on code in PR #357:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/357#discussion_r958531909
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/FlinkUtils.java:
##########
@@ -187,6 +187,18 @@ public static void setGenerationAnnotation(Configuration
conf, Long generation)
conf.set(KubernetesConfigOptions.JOB_MANAGER_ANNOTATIONS, labels);
}
+ public static void setTaskmanagerGenerationAnnotation(Configuration conf,
Long generation) {
+ if (generation == null) {
+ return;
+ }
+ var labels =
+ new HashMap<>(
+
conf.getOptional(KubernetesConfigOptions.TASK_MANAGER_ANNOTATIONS)
+ .orElse(Collections.emptyMap()));
+ labels.put(CR_GENERATION_LABEL, generation.toString());
+ conf.set(KubernetesConfigOptions.TASK_MANAGER_ANNOTATIONS, labels);
+ }
Review Comment:
I have taken the TASK_MANAGER/JOBMANAGER_ANNOTATIONS config option as param
to refactor annotation generation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
