Grypse commented on code in PR #357:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/357#discussion_r958526678
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java:
##########
@@ -417,6 +421,33 @@ private static String createTempFile(Pod podTemplate)
throws IOException {
return tmp.getAbsolutePath();
}
+ private static void setPvcTemplate(
+ List<PersistentVolumeClaim> persistentVolumeClaims,
+ Configuration effectiveConfig,
+ boolean isJm)
+ throws IOException {
+ if (persistentVolumeClaims != null) {
+ final ConfigOption<String> pvcConfigOptions =
+ isJm
+ ?
StandaloneKubernetesConfigOptionsInternal.JOB_MANAGER_PVC_TEMPLATE
+ :
StandaloneKubernetesConfigOptionsInternal.TASK_MANAGER_PVC_TEMPLATE;
+ effectiveConfig.setString(
+ pvcConfigOptions, String.join(",",
createPvcTempFile(persistentVolumeClaims)));
+ }
+ }
+
+ private static List<String> createPvcTempFile(List<PersistentVolumeClaim>
pvcTemplates)
Review Comment:
Added the newly created files to the list of cleaned up files to the method
of `cleanupTmpFiles `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
