wangxlong commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r547636537
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/table/descriptors/JdbcValidator.java
##########
@@ -42,6 +42,7 @@
public static final String CONNECTOR_DRIVER = "connector.driver";
public static final String CONNECTOR_USERNAME = "connector.username";
public static final String CONNECTOR_PASSWORD = "connector.password";
+ public static final String CONNECTOR_MAX_RETRY_TIMEOUT =
"connection.max-retry-timeout";
Review comment:
Would be better as follow,
> public static final String CONNECTOR_CONNECTION_MAX_RETRY_TIMEOUT =
"connector .connection.max-retry-timeout";
And also add this property to the `connect.md` and `connect.zh.md` docs for
jdbc connector.
##########
File path:
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTableSourceSinkFactoryTest.java
##########
@@ -75,6 +76,7 @@ public void testJdbcCommonProperties() {
.setDriverName("org.apache.derby.jdbc.EmbeddedDriver")
.setUsername("user")
.setPassword("pass")
+ .setConnectionCheckTimeoutSeconds(120)
Review comment:
Could you also add a invalid value test which is smaller than 1 second
in testJdbcValidation?
##########
File path:
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTableSourceSinkFactoryTest.java
##########
@@ -75,6 +76,7 @@ public void testJdbcCommonProperties() {
.setDriverName("org.apache.derby.jdbc.EmbeddedDriver")
.setUsername("user")
.setPassword("pass")
+ .setConnectionCheckTimeoutSeconds(120)
Review comment:
Could you also add a invalid value test which is less than 1 second in
testJdbcValidation?
##########
File path:
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTableSourceSinkFactoryTest.java
##########
@@ -75,6 +76,7 @@ public void testJdbcCommonProperties() {
.setDriverName("org.apache.derby.jdbc.EmbeddedDriver")
.setUsername("user")
.setPassword("pass")
+ .setConnectionCheckTimeoutSeconds(120)
Review comment:
Could you also add a invalid value test which is less than 1 second in
testJdbcValidation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
