xiaoHoly commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r547610189
##########
File path:
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactoryTest.java
##########
@@ -339,6 +341,18 @@ public void testJdbcValidation() {
"The value of 'sink.max-retries' option
shouldn't be negative, but is -1.")
.isPresent());
}
+
+ // connection.max-retry-timeout should be positive
Review comment:
your description is more appropriate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
