wangxlong commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r547624361
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcLookupFunction.java
##########
@@ -177,7 +178,7 @@ public void eval(Object... keys) {
}
try {
- if
(!dbConn.isValid(CONNECTION_CHECK_TIMEOUT_SECONDS)) {
+ if
(!dbConn.isValid(connectionCheckTimeoutSeconds)) {
Review comment:
Sorry, you are right. And add a invalid value which is less than 1
second in `testJdbcValidation`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
