V1ncentzzZ commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r547609486
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactory.java
##########
@@ -324,6 +332,13 @@ private void validateConfigOptions(ReadableConfig config) {
SINK_MAX_RETRIES.key(),
config.get(SINK_MAX_RETRIES)));
}
+
+ if (config.get(MAX_RETRY_TIMEOUT).getSeconds() <= 0) {
+ throw new IllegalArgumentException(String.format(
+ "The value of '%s' option must be in second
granularity and shouldn't be smaller than 1 second, but is %s.",
+ MAX_RETRY_TIMEOUT.key(),
+
config.get(ConfigOptions.key(MAX_RETRY_TIMEOUT.key()).stringType().noDefaultValue())));
Review comment:
I'm not sure the second placeholder maybe
`config.get(MAX_RETRY_TIMEOUT).getSeconds()` instead of
`config.get(ConfigOptions.key(MAX_RETRY_TIMEOUT.key()).stringType().noDefaultValue()))`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
