xiaoHoly commented on a change in pull request #14387:
URL: https://github.com/apache/flink/pull/14387#discussion_r547735809
##########
File path:
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTableSourceSinkFactoryTest.java
##########
@@ -269,6 +269,17 @@ public void testJdbcValidation() {
fail("exception expected");
} catch (ValidationException ignored) {
}
+
+ // connection.max-retry-timeout property is smaller than 1
second
+ try {
+ Map<String, String> properties = getBasicProperties();
+
properties.put("connector.connection.max-retry-timeout", "100ms");
+
+
TableFactoryService.find(StreamTableSourceFactory.class, properties)
+ .createStreamTableSource(properties);
+ fail("exception expected");
+ } catch (ValidationException ignored) {
+ }
Review comment:
other property don't add the expected message,i think it stand for the
expected message when catching the exception in the test perspective
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
