wuchong commented on a change in pull request #11321: [FLINK-15585] [table]
Improve function identifier string in plan digest
URL: https://github.com/apache/flink/pull/11321#discussion_r402146127
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/expressions/converter/LegacyScalarFunctionConvertRule.java
##########
@@ -42,11 +42,10 @@
FunctionDefinition def = call.getFunctionDefinition();
if (def instanceof ScalarFunctionDefinition) {
ScalarFunction scalaFunc = ((ScalarFunctionDefinition)
def).getScalarFunction();
- FunctionIdentifier identifier =
call.getFunctionIdentifier()
-
.orElse(FunctionIdentifier.of(scalaFunc.functionIdentifier()));
+ FunctionIdentifier identifier =
FunctionIdentifier.of(((ScalarFunctionDefinition) def).getName());
SqlFunction sqlFunction =
UserDefinedFunctionUtils.createScalarSqlFunction(
identifier,
- scalaFunc.toString(),
+ identifier.toString(),
Review comment:
Do we need to change this? The second parameter is `displayName` which is
used for logging. And I think a simple class name is more readable than
identifier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
