wuchong commented on a change in pull request #11321: [FLINK-15585] [table]
Improve function identifier string in plan digest
URL: https://github.com/apache/flink/pull/11321#discussion_r402018101
##########
File path:
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/UserDefinedFunction.java
##########
@@ -45,10 +45,19 @@
/**
* Returns a unique, serialized representation for this function.
+ *
+ * <p>If the function has no constructor or only one constructor
without any parameter,
Review comment:
This implementation is not matched to the PR description. I think we should
use full calss name only when it doesn't contain fields. Single constructor
without parameters can't guarantee it is immutable. It may contains some
variable and may be changed after constructed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
