wuchong commented on a change in pull request #11321: [FLINK-15585] [table]
Improve function identifier string in plan digest
URL: https://github.com/apache/flink/pull/11321#discussion_r402123499
##########
File path:
flink-table/flink-table-planner-blink/src/test/resources/org/apache/flink/table/planner/plan/batch/table/stringexpr/CorrelateStringExpressionTest.xml
##########
@@ -56,13 +56,13 @@ Calc(select=[c, s])
LogicalProject(c=[$2], s=[$3])
+- LogicalCorrelate(correlation=[$cor0], joinType=[inner],
requiredColumns=[{}])
:- LogicalTableScan(table=[[default_catalog, default_database, Table1,
source: [TestTableSource(a, b, c)]]])
- +-
LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$774a5145e3fba9ca5b92e3e71a308c36($2,
_UTF-16LE'$')], rowType=[RecordType(VARCHAR(2147483647) s)],
elementType=[class [Ljava.lang.Object;])
+ +-
LogicalTableFunctionScan(invocation=[org$apache$flink$table$planner$utils$TableFunc1$($2,
_UTF-16LE'$')], rowType=[RecordType(VARCHAR(2147483647) s)],
elementType=[class [Ljava.lang.Object;])
]]>
</Resource>
<Resource name="planAfter">
<![CDATA[
Calc(select=[c, s])
-+-
Correlate(invocation=[org$apache$flink$table$planner$utils$TableFunc1$774a5145e3fba9ca5b92e3e71a308c36($2,
_UTF-16LE'$')], correlate=[table(TableFunc1(c,_UTF-16LE'$'))],
select=[a,b,c,s], rowType=[RecordType(INTEGER a, BIGINT b, VARCHAR(2147483647)
c, VARCHAR(2147483647) s)], joinType=[INNER])
++- Correlate(invocation=[org$apache$flink$table$planner$utils$TableFunc1$($2,
_UTF-16LE'$')],
correlate=[table(org$apache$flink$table$planner$utils$TableFunc1$(c,_UTF-16LE'$'))],
select=[a,b,c,s], rowType=[RecordType(INTEGER a, BIGINT b, VARCHAR(2147483647)
c, VARCHAR(2147483647) s)], joinType=[INNER])
Review comment:
Should we improve the digest of Correlate? It seems that the `invocation`
and `correlate` are duplicate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
