wuchong commented on a change in pull request #11321: [FLINK-15585] [table]
Improve function identifier string in plan digest
URL: https://github.com/apache/flink/pull/11321#discussion_r402158984
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/plan/stream/table/validation/TableAggregateValidationTest.scala
##########
@@ -116,16 +116,16 @@ class TableAggregateValidationTest extends TableTestBase
{
@Test
def testInvalidAliasWithWrongNumber(): Unit = {
+ val func = new EmptyTableAggFunc
expectedException.expect(classOf[ValidationException])
expectedException.expectMessage("List of column aliases must have same
degree as " +
"table; the returned table of function " +
- "'org.apache.flink.table.planner.utils.EmptyTableAggFunc' has 2 columns,
" +
+ s"'${func.functionIdentifier()}' has 2 columns, " +
Review comment:
I think displaying a class name or a registered name is better than a
functionIdentifier here.
If we want to support this, I think we may need to refactor
`TableAggregateFunctionDefinition` `AggregateFunctionDefinition`, etc... to
have an `FunctionIdentifier` and a `displayName`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
