wuchong commented on a change in pull request #11321: [FLINK-15585] [table]
Improve function identifier string in plan digest
URL: https://github.com/apache/flink/pull/11321#discussion_r401445976
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/utils/factories/CalculatedTableFactory.java
##########
@@ -105,9 +106,16 @@ private CalculatedQueryOperation createFunctionCall(
.map(FunctionIdentifier::asSummaryString)
.orElse(functionDefinition.toString()));
+ String name;
+ if (functionDefinition instanceof
TableFunctionDefinition) {
+ name = ((TableFunctionDefinition)
functionDefinition).getName();
+ } else {
+ throw new ValidationException("Unsupported
FunctionDefinition: " + functionDefinition.getKind());
Review comment:
Why not support other function definitions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
