tillrohrmann commented on a change in pull request #9105:
[FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory
size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#discussion_r308263495
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerFactory.java
##########
@@ -59,4 +63,16 @@ default String generateEndpointIdWithUUID() {
default String getEndpointId() {
return ResourceManager.RESOURCE_MANAGER_NAME;
}
+
+ default Configuration getResourceManagerConfiguration(Configuration
flinkConfig) {
Review comment:
Why do we make this method part of the `ResourceManagerFactory`? It seems to
me that we are mixing concerns here (creating a `ResourceManager` vs. properly
setting up the ResourceManager's `configuration`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
