tillrohrmann commented on a change in pull request #9105:
[FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory
size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#discussion_r306381627
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -1203,6 +1221,16 @@ protected int getNumberRequiredTaskManagerSlots() {
// Helper methods
//
------------------------------------------------------------------------
+ @VisibleForTesting
+ Configuration getFlinkConfig() {
+ return flinkConfig;
+ }
+
+ @VisibleForTesting
+ Collection<ResourceProfile> getSlotsPerWorker() {
+ return slotsPerWorker;
+ }
Review comment:
Getting access to internal state is usually an indicator that our class
under test is too powerful and is not well suited for testing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
