tillrohrmann commented on a change in pull request #9105:
[FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory
size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#discussion_r308261020
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosResourceManagerFactory.java
##########
@@ -99,4 +100,11 @@ public MesosResourceManagerFactory(@Nonnull MesosServices
mesosServices, @Nonnul
webInterfaceUrl,
jobManagerMetricGroup);
}
+
+ @Override
+ public Configuration getResourceManagerConfiguration(Configuration
flinkConfig) {
+ final Configuration config = new Configuration(flinkConfig);
+ config.setString(TaskManagerOptions.MANAGED_MEMORY_SIZE,
flinkConfig.getInteger(MesosTaskManagerParameters.MESOS_RM_TASKS_MEMORY_MB) +
"m");
Review comment:
Isn't `MESOS_RM_TASKS_MEMORY_MB` the memory a Mesos task should get assigned
(aka the total container memory size)? Why did we introduce this change in this
PR? It seems a bit unrelated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
