tillrohrmann commented on a change in pull request #9105:
[FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory
size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#discussion_r306378649
##########
File path:
flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnConfigurationITCase.java
##########
@@ -208,4 +215,12 @@ private boolean
hasTaskManagerConnectedAndReportedSlots(Collection<TaskManagerIn
return taskManagerInfo.getNumberSlots() > 0;
}
}
+
+ private static int calculateManagedMemorySizeMB(Configuration
originalConfiguration, int numSlotsPerTaskManager) {
+ Configuration configuration = new
Configuration(originalConfiguration); // copy, because we alter the config
Review comment:
It is a bit weird that we have to do something like this in a test. This
might indicate a design flaw of the
`YarnResourceManager#updateTaskManagerConfigAndCreateWorkerSlotProfiles` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
