tillrohrmann commented on a change in pull request #9105:
[FLINK-13241][Yarn/Mesos] Fix Yarn/MesosResourceManager setting managed memory
size into wrong configuration instance.
URL: https://github.com/apache/flink/pull/9105#discussion_r307805904
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
##########
@@ -184,7 +183,9 @@ public YarnResourceManager(
this.defaultCpus =
flinkConfig.getInteger(YarnConfigOptions.VCORES, numberOfTaskSlots);
this.resource =
Resource.newInstance(defaultTaskManagerMemoryMB, defaultCpus);
- this.slotsPerWorker =
updateTaskManagerConfigAndCreateWorkerSlotProfiles(flinkConfig,
defaultTaskManagerMemoryMB, numberOfTaskSlots);
+ this.defaultTaskManagerParameters =
ContaineredTaskManagerParameters.create(flinkConfig,
defaultTaskManagerMemoryMB, numberOfTaskSlots);
Review comment:
I think this change isn't complete yet. The method
`createTaskExecutorLaunchContext` recreates a
`ContaineredTaskManagerParameters` instance, for example. I would suggest that
we pass in a `ContaineredTaskManagerParameters` instance to the
`YarnResourceManager` and reuse this instance within this class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
