azagrebin commented on a change in pull request #8778:
[FLINK-12615][coordination] Track partitions on JM
URL: https://github.com/apache/flink/pull/8778#discussion_r295728459
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1063,15 +1063,7 @@ void markFinished(Map<String, Accumulator<?, ?>>
userAccumulators, IOMetrics met
IntermediateResultPartition[] allPartitions = finishedPartition
.getIntermediateResult().getPartitions();
-
PartitionTable<ResourceID> partitionTable =
vertex.getExecutionGraph().getPartitionTable();
- for
(IntermediateResultPartition partition : allPartitions) {
-
ResultPartitionDeploymentDescriptor descriptor =
producedPartitions.get(partition.getPartitionId());
- if
(!descriptor.isReleasedOnConsumption() &&
descriptor.getShuffleDescriptor().hasLocalResources().isPresent()) {
-
partitionTable.startTrackingPartition(
-
getAssignedResourceLocation().getResourceID(),
-
descriptor.getShuffleDescriptor().getResultPartitionID());
- }
- }
+
startTrackingUnreleasedPartitions(allPartitions);
Review comment:
looks like it can be done before the for loop:
`startTrackingUnreleasedPartitions(getVertex().finishAllBlockingPartitions())`
now it processes a lot duplicates
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
