azagrebin commented on a change in pull request #8778:
[FLINK-12615][coordination] Track partitions on JM
URL: https://github.com/apache/flink/pull/8778#discussion_r295713085
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/partition/PartitionTable.java
##########
@@ -88,14 +87,14 @@ void stopTrackingPartition(JobID jobId, ResultPartitionID
partitionId) {
/**
* Stops the tracking of the given set of partitions for the given job.
*/
- void stopTrackingPartitions(JobID jobId, Collection<ResultPartitionID>
partitionIds) {
- Preconditions.checkNotNull(jobId);
+ void stopTrackingPartitions(K key, Collection<ResultPartitionID>
partitionIds) {
+ Preconditions.checkNotNull(key);
Preconditions.checkNotNull(partitionIds);
// If the JobID is unknown we do not fail here, in line with
ShuffleEnvironment#releaseFinishedPartitions
Review comment:
also this comment is outdated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
