walterddr commented on a change in pull request #7607: [FLINK-10076][table] Upgrade Calcite dependency to 1.18 URL: https://github.com/apache/flink/pull/7607#discussion_r254910013
########## File path: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/batch/sql/GroupWindowTest.scala ########## @@ -326,26 +326,22 @@ class GroupWindowTest extends TableTestBase { unaryNode( "DataSetCalc", batchTableNode(0), - term("select", "rowtime", "c", - "*(c, c) AS $f2", "*(c, c) AS $f3", "*(c, c) AS $f4", "*(c, c) AS $f5") + term("select", "rowtime", "c", "*(c, c) AS $f2") ), term("window", TumblingGroupWindow('w$, 'rowtime, 900000.millis)), term("select", "SUM($f2) AS $f0", "SUM(c) AS $f1", "COUNT(c) AS $f2", - "SUM($f3) AS $f3", - "SUM($f4) AS $f4", - "SUM($f5) AS $f5", "start('w$) AS w$start", "end('w$) AS w$end", "rowtime('w$) AS w$rowtime") ), term("select", - "CAST(/(-($f0, /(*($f1, $f1), $f2)), $f2)) AS EXPR$0", - "CAST(/(-($f3, /(*($f1, $f1), $f2)), CASE(=($f2, 1), null, -($f2, 1)))) AS EXPR$1", - "CAST(POWER(/(-($f4, /(*($f1, $f1), $f2)), $f2), 0.5)) AS EXPR$2", - "CAST(POWER(/(-($f5, /(*($f1, $f1), $f2)), CASE(=($f2, 1), null, -($f2, 1))), 0.5)) " + + "/(-($f0, /(*($f1, $f1), $f2)), $f2) AS EXPR$0", Review comment: For some reason the last comment didn't go through, this is optimized due to [CALCITE-2695] in RexSimplify ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services